Separate build and test for flutter_gallery__transition_perf task
#103550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
CaseyHillers
approved these changes
May 12, 2022
| /// Temp function during gallery tests transition to build+test model. | ||
| /// | ||
| /// https://github.com/flutter/flutter/issues/103542 | ||
| TaskFunction createGalleryTransitionBuildTest(List<String> args, {bool semanticsEnabled = false}) { |
Contributor
There was a problem hiding this comment.
LGTM. Can we add enable one of these tests in presubmit to ensure this won't break the tree?
Contributor
Author
There was a problem hiding this comment.
These tests are not configured by .ci.yaml, but the devicelab_staging_config.star. So will not affect the tree.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of #103542 to refactor
flutter_gallery__transition_perfto build+test format.