Avoid analyzing API example code twice, clean-up #103548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
Member
Author
|
/cc @HansMuller This should unblock the analyzer issue in your code sample that you pinged me about the other day. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we were analyzing the API examples in
examples/apitwice as part offlutter analyze --flutter-repoand as part of runningdev/bots/analyze_sample_code.dart. This change removes the duplication.All changes included in this PR:
examples/apifromanalyze_sample_code.dart(this is already covered byflutter analyze --flutter-repo)analyze_sample_code.darttoanalyze_snippet_code.dartsince it is now only in charge of analyzing{@tool snippet}sectionspubspec.yamlfromexamples/apito analyze snippets for consistency between snippets and samplesanalysis_options.yamlfromexamples/apito analyze snippets for consistency between snippets and samplesNote to reviewers: git/github unhelpfuly thinks that
analyze_snippet_code.dartandanalyze_snippet_code_test.dartare NEW files instead of recognizing that the files just have been renamed. It may be helpful to review the two commits of the PR separately. The first commit just contains renaming the files. The second commit then shows the modifications to the renamed files as a proper diff.