Skip to content

Enforce minimum plugin version iOS 11 #103545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 13, 2022
Merged

Enforce minimum plugin version iOS 11 #103545

fluttergithubbot merged 1 commit into from
May 13, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 11, 2022

App-side, enforce that plugins should only be built for iOS 11 and higher.

Part of #101959. Will allow the engine framework to increase the minimum to iOS 11 since apps will no longer try to build plugins for iOS 9 linking against Flutter.framework.

Will unblock #101964

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 11, 2022
@jmagman jmagman self-assigned this May 11, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 11, 2022
@jmagman jmagman mentioned this pull request May 11, 2022
Closed
11 tasks
jmagman
jmagman commented May 11, 2022
View reviewed changes
dev/devicelab/lib/tasks/plugin_tests.dart
if (podsProjectContent.contains('IPHONEOS_DEPLOYMENT_TARGET = 7')) {
// in _reduceDarwinPluginMinimumVersion to 10, which is below the target version of 11.
if (podsProjectContent.contains('IPHONEOS_DEPLOYMENT_TARGET = 10')) {
throw TaskResult.failure('Plugin build setting IPHONEOS_DEPLOYMENT_TARGET not removed');
Copy link
Member Author

@jmagman jmagman May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that with the test change and without podhelper.rb on master, the test fails (proving this test is validating the correct thing).

[plugin_test_ios] Process terminated with exit code 0.
Task result:
{
  "success": false,
  "reason": "Plugin build setting IPHONEOS_DEPLOYMENT_TARGET not removed"
}

christopherfujino
christopherfujino approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 12, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan-g
stuartmorgan-g approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Once this lands it would be nice to build everything in flutter/plugins and look for deprecation warnings (we may already have suppressed them all due to people who were already using 11+ for their apps filing issues, but maybe not), so we can fix those before this is widely rolled out and cut down on the number of one-off bugs about warnings.

@fluttergithubbot fluttergithubbot merged commit 036cae3 into flutter:master May 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
4767d78
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
4d0cfea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
5f0a926
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
33f12ef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
f59590c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
96bc607
@jmagman jmagman deleted the min-plugin-11 branch May 13, 2022 23:34
@jmagman jmagman mentioned this pull request May 13, 2022
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
daf8523
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
89f7147
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
4d257ad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
9ff7747
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
530aade
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
5124fed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
78d62e8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
74a0581
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
01b57d9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
93fb313
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
e83537b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
b40dcd6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
c2e2d49
@jmagman jmagman mentioned this pull request May 16, 2022
Closed
@jmagman jmagman mentioned this pull request Jul 15, 2022
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
74f65c3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
036cae3 Enforce minimum plugin version iOS 11 (flutter/flutter#103545)
de37aac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @fluttergithubbot @stuartmorgan-g @christopherfujino