-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Accessibility troubleshooting docs for TextField widgets #103521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility troubleshooting docs for TextField widgets #103521
Conversation
| /// | ||
| /// {@tool snippet} | ||
| /// On iOS, the on-screen keyboard may announce the most recent input | ||
| /// incorrectly when we insert a thousands separator to a currency value text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid we
| /// accessibility announcement. | ||
| /// | ||
| /// {@tool snippet} | ||
| /// On iOS, the on-screen keyboard may announce the most recent input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it work on Android?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SemanticsService.announce should but I'm not sure the same problem exists on Android (the internal issue report didn't mention anything about Android so I assume it works fine even without the workaround on Android).
| /// field as a US currency value. | ||
| /// | ||
| /// ```dart | ||
| /// onChanged: (String newText) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put an entire TextField or editable text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm setting this up as a template to be used in TextField CupertinoTextField as well so I'm trying to avoid using the name of the exact widget. I removed the tool marks maybe that will prevent the analyzer from analyzing this.
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #101707
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.