Skip to content

Set presubmit false for staging targets in ci.yaml #103509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 11, 2022
Merged

Set presubmit false for staging targets in ci.yaml #103509

fluttergithubbot merged 1 commit into from
May 11, 2022

Conversation

@yusuf-goog
Copy link
Contributor

@yusuf-goog yusuf-goog commented May 11, 2022 •
edited
Loading

Bug:103507

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yusuf-goog yusuf-goog requested a review from keyonghan as a code owner May 11, 2022 16:27
@yusuf-goog
Copy link
Contributor Author

yusuf-goog commented May 11, 2022

Fixes #103507

keyonghan
keyonghan approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yusuf-goog yusuf-goog self-assigned this May 11, 2022
@fluttergithubbot fluttergithubbot merged commit 5e85d23 into flutter:master May 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2022
@engine-flutter-autoroll
5e85d23 Set presubmit false for staging targets in ci.yaml (flutter/f…
23c8653 
…lutter#103509)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 12, 2022
@engine-flutter-autoroll
5e85d23 Set presubmit false for staging targets in ci.yaml (flutter/f…
efad8b2 
…lutter#103509)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5e85d23 Set presubmit false for staging targets in ci.yaml (flutter/f…
bff2c7c 
…lutter#103509)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5e85d23 Set presubmit false for staging targets in ci.yaml (flutter/f…
4f1684a 
…lutter#103509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yusuf-goog yusuf-goog

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yusuf-goog @keyonghan @fluttergithubbot