Skip to content

Add blank line after first sentence of doc comment for CheckedModeBanner #103490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 13, 2022
Merged

Add blank line after first sentence of doc comment for CheckedModeBanner #103490

fluttergithubbot merged 1 commit into from
May 13, 2022

Conversation

@nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented May 11, 2022

Regarding Effective Dart, we should separate the first sentence of a doc comment into its own paragraph.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 11, 2022
goderbauer
goderbauer approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ waiting for tree to go green labels May 12, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 13, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@nilsreichardt
Copy link
Contributor Author

nilsreichardt commented May 13, 2022

@Piinks What can I do to fix the checks?

@fluttergithubbot fluttergithubbot merged commit 2b2cda1 into flutter:master May 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
2b2cda1 Add blank line after first sentence of doc comment for `Check…
8488427 
…edModeBanner` (flutter/flutter#103490)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
2b2cda1 Add blank line after first sentence of doc comment for `Check…
298647f 
…edModeBanner` (flutter/flutter#103490)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2b2cda1 Add blank line after first sentence of doc comment for `Check…
5dcb1d5 
…edModeBanner` (flutter/flutter#103490)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2b2cda1 Add blank line after first sentence of doc comment for `Check…
2aee014 
…edModeBanner` (flutter/flutter#103490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nilsreichardt @fluttergithubbot @goderbauer @Piinks