Provide flutter sdk kernel files to dwds launcher instead of dart ones #103436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
packages/flutter_tools/lib/src/isolated/sdk_web_configuration.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/web.shard/sdk_web_configuration_test.dart
Outdated
Show resolved
Hide resolved
christopherfujino
approved these changes
May 10, 2022
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM with 1 nit about initializing provider in the test setUp()
christopherfujino
approved these changes
May 11, 2022
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Thanks so much for submitting this!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide flutter SDK kernel files to dwds launcher instead of dart ones.
Flutter SDK adds libraries to the dart SDK kernel files. Passing flutter SDK will make those additional libraries available for expression compilation.
Closes: #101639
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.