Skip to content

[Reland] Assert there are Scaffolds to present to for snackbars and banners #103426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
May 10, 2022
Merged

[Reland] Assert there are Scaffolds to present to for snackbars and banners #103426

fluttergithubbot merged 2 commits into from
May 10, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented May 10, 2022

Original PR #103006
Fixes #103004

The only change from the original PR is that I added the same check for banners.
This was reverted because some customers had tests for individual widgets that present snackbars, but the tests did not include a scaffold.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 10, 2022
@Piinks Piinks requested review from TahaTesser and craiglabenz May 10, 2022 16:34
craiglabenz
craiglabenz approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still love it

@fluttergithubbot fluttergithubbot merged commit 171d8c1 into flutter:master May 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2022
@engine-flutter-autoroll
171d8c1 [Reland] Assert there are Scaffolds to present to for snackba…
8353a0d 
…rs and banners (flutter/flutter#103426)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 12, 2022
@engine-flutter-autoroll
171d8c1 [Reland] Assert there are Scaffolds to present to for snackba…
082af49 
…rs and banners (flutter/flutter#103426)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
171d8c1 [Reland] Assert there are Scaffolds to present to for snackba…
db773b5 
…rs and banners (flutter/flutter#103426)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
171d8c1 [Reland] Assert there are Scaffolds to present to for snackba…
c112e7e 
…rs and banners (flutter/flutter#103426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craiglabenz craiglabenz craiglabenz approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScaffoldMessenger.showSnackBar doesn't check if there are any Scaffolds to present in

4 participants

@Piinks @craiglabenz @TahaTesser @fluttergithubbot