Skip to content

Fix ThemeData extension throws when the ThemeExtension not found #103343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 11, 2022
Merged

Fix ThemeData extension throws when the ThemeExtension not found #103343

fluttergithubbot merged 1 commit into from
May 11, 2022

Conversation

@SuperPenguin
Copy link
Contributor

@SuperPenguin SuperPenguin commented May 9, 2022

The cast

flutter/packages/flutter/lib/src/material/theme_data.dart

Line 1080 in 0656a5c

T? extension<T>() => extensions[T] as T;
causing error when the T extension is not in extensions
The PR change the cast to as T?

Fixes #103313

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 9, 2022
guidezpl
guidezpl approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you!

werainkhatri
werainkhatri approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f5fb9e8 into flutter:master May 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2022
@engine-flutter-autoroll
f5fb9e8 Fix ThemeData extension throws when the ThemeExtension not fo…
0fe5a7a 
…und (flutter/flutter#103343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 12, 2022
@engine-flutter-autoroll
f5fb9e8 Fix ThemeData extension throws when the ThemeExtension not fo…
3da08d9 
…und (flutter/flutter#103343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
f5fb9e8 Fix ThemeData extension throws when the ThemeExtension not fo…
808422a 
…und (flutter/flutter#103343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
f5fb9e8 Fix ThemeData extension throws when the ThemeExtension not fo…
9f5f88a 
…und (flutter/flutter#103343)
@SuperPenguin SuperPenguin deleted the fix_theme_extension branch September 20, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ThemeData extension method throw exception when the ThemeExtension is null

4 participants

@SuperPenguin @guidezpl @werainkhatri @fluttergithubbot