Skip to content

remove unnecessary .toString() #103226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 6, 2022
Merged

remove unnecessary .toString() #103226

fluttergithubbot merged 1 commit into from
May 6, 2022

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented May 6, 2022

This will avoid new diagnostics after changes on noop_primitive_operations introduced by dart-archive/linter#3379

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 6, 2022
@a14n a14n requested a review from goderbauer May 6, 2022 20:49
goderbauer
goderbauer approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@a14n a14n mentioned this pull request May 6, 2022
Merged
@fluttergithubbot fluttergithubbot merged commit d40ee21 into flutter:master May 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2022
@engine-flutter-autoroll
d40ee21 remove unnecessary .toString() (flutter/flutter#103226)
90ed3ad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 7, 2022
@engine-flutter-autoroll
d40ee21 remove unnecessary .toString() (flutter/flutter#103226)
9c37be1
@a14n a14n deleted the unnecessary-toString branch May 7, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a14n @goderbauer @fluttergithubbot