Skip to content

Increase Tooltip font size on Desktop #103189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 6, 2022
Merged

Increase Tooltip font size on Desktop #103189

fluttergithubbot merged 1 commit into from
May 6, 2022

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented May 6, 2022

Description

This PR increase tooltip default font size on Windows and Linux for readibility.
Material team is ok with it from this comment :
#71429 (comment)

Related Issue

Fixes #71429

Tests

Add 2 tests.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 6, 2022
@bleroux bleroux requested a review from chunhtai May 6, 2022 18:04
chunhtai
chunhtai reviewed May 6, 2022
View reviewed changes
packages/flutter/lib/src/material/tooltip.dart Outdated
Copy link
Contributor

@chunhtai chunhtai May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue also mentioned macOS, am i missing somethig?

This legibility issue also applies to Linux and MacOS platforms when device pixel ratio 1.0 is used.

Copy link
Contributor Author

@bleroux bleroux May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I read all the comments on the previous issue #71052 that mainly mentioned Windows and Linux, and I didn't notice that MacOS is included in the new issue description. Good catch! That's make this change even simpler.

packages/flutter/test/material/tooltip_test.dart Outdated
Copy link
Contributor

@chunhtai chunhtai May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed description doesn't seem to add more value.

packages/flutter/test/material/tooltip_test.dart Outdated
Copy link
Contributor

@chunhtai chunhtai May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do a switch case on defaultTargetPlatform and do different expect value instead of removing the check. But this may not be needed if macos also uses 12px

@bleroux bleroux force-pushed the tooltip_font_size branch from 9759394 to f4f8e4d Compare May 6, 2022 18:50
@bleroux bleroux requested a review from chunhtai May 6, 2022 19:21
chunhtai
chunhtai approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux bleroux changed the title Increase Tooltip font size on Windows and Linux Increase Tooltip font size on Desktop May 6, 2022
@fluttergithubbot fluttergithubbot merged commit cfc5dc2 into flutter:master May 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2022
@engine-flutter-autoroll
cfc5dc2 Increase Tooltip font size on Desktop (flutter/flutter#103189)
a1b539e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 7, 2022
@engine-flutter-autoroll
cfc5dc2 Increase Tooltip font size on Desktop (flutter/flutter#103189)
5ca052d
@bleroux bleroux deleted the tooltip_font_size branch May 7, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default tooltip style is not legible on desktop and web builds with device pixel ratio 1.0

3 participants

@bleroux @chunhtai @fluttergithubbot