-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Adding linux VM staging tests to .ci.yaml #103165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Initial test with 2 tasks was successful, moving the other tests in as a precursor to migration to Ubuntu bots.
|
@keyonghan the 2 tests previously checked in came in as successfully, and the dashboard hides them by default. One uncovered the goldens mismatch (as expected for some tests), which was hidden because of other failure. Moving all the linux VM ones to have them run as staging jobs. These are VM tests and so not under the luci scheduler, which @CaseyHillers said would not badly impact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause lots of flake noises affecting different team's triage process. We need to hold on this change before excluding these staging builders from the flake bot.
#103081 (comment)
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
|
This change now has ignore_flakiness and presubmit tags. |
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This reverts commit 041999c.
Initial test with 2 tasks was successful, moving the
other tests in as a precursor to migration to
Ubuntu bots.
Bug: 102406
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.