Skip to content

Conversation

@yusuf-goog
Copy link
Contributor

@yusuf-goog yusuf-goog commented May 6, 2022

Initial test with 2 tasks was successful, moving the
other tests in as a precursor to migration to
Ubuntu bots.

Bug: 102406

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Initial test with 2 tasks was successful, moving the
other tests in as a precursor to migration to
Ubuntu bots.
@yusuf-goog yusuf-goog requested a review from keyonghan as a code owner May 6, 2022 00:21
@yusuf-goog
Copy link
Contributor Author

@keyonghan the 2 tests previously checked in came in as successfully, and the dashboard hides them by default.

One uncovered the goldens mismatch (as expected for some tests), which was hidden because of other failure.

Moving all the linux VM ones to have them run as staging jobs.

These are VM tests and so not under the luci scheduler, which @CaseyHillers said would not badly impact refresh-chrome-bot-status

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause lots of flake noises affecting different team's triage process. We need to hold on this change before excluding these staging builders from the flake bot.
#103081 (comment)

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels May 9, 2022
@flutter-dashboard
Copy link

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

@yusuf-goog
Copy link
Contributor Author

This change now has ignore_flakiness and presubmit tags.

@yusuf-goog yusuf-goog requested a review from keyonghan May 11, 2022 17:54
@yusuf-goog yusuf-goog dismissed keyonghan’s stale review May 11, 2022 17:55

ignore_flakiness implemented.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants