Skip to content

Fix a [CupertinoDatePicker] semantics bug #103123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 6, 2022
Merged

Fix a [CupertinoDatePicker] semantics bug #103123

fluttergithubbot merged 1 commit into from
May 6, 2022

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented May 5, 2022

Fixes #98567

The FixedExtentScrollController.selectedItem maybe less than zero.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels May 5, 2022
@nilsreichardt nilsreichardt mentioned this pull request May 5, 2022
Closed
@xu-baolin xu-baolin requested review from jonahwilliams May 6, 2022 10:20
jonahwilliams
jonahwilliams approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit a7a72ce into flutter:master May 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2022
@engine-flutter-autoroll
a7a72ce Fix a [CupertinoDatePicker] semantics bug (flutter/flutter#10…
8b2cfe7 
…3123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 6, 2022
@engine-flutter-autoroll
a7a72ce Fix a [CupertinoDatePicker] semantics bug (flutter/flutter#10…
d60e60b 
…3123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 6, 2022
@engine-flutter-autoroll
a7a72ce Fix a [CupertinoDatePicker] semantics bug (flutter/flutter#10…
75e8d91 
…3123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CupertinoDatePicker] Accessibility decrease action doesn't go beyond the initial date

3 participants

@xu-baolin @jonahwilliams @fluttergithubbot