Skip to content

Add missing HIG links to cupertino documentation #103110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 1 commit into from
May 5, 2022
Merged

Add missing HIG links to cupertino documentation #103110

guidezpl merged 1 commit into from
May 5, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 5, 2022 •
edited
Loading

#72926, #102812

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels May 5, 2022
@guidezpl guidezpl requested a review from TahaTesser May 5, 2022 06:20
@TahaTesser
Copy link
Member

TahaTesser commented May 5, 2022 •
edited
Loading

@guidezpl
Could you please remove the closing issue tag?
There are a few more doc PRs pending :)

@guidezpl
Copy link
Member Author

guidezpl commented May 5, 2022

Sure!

@guidezpl guidezpl merged commit dfa4fd2 into flutter:master May 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2022
@engine-flutter-autoroll
dfa4fd2 Add missing HIG links to cupertino documentation (flutter/flu…
b63dfbf 
…tter#103110)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 5, 2022
@engine-flutter-autoroll
dfa4fd2 Add missing HIG links to cupertino documentation (flutter/flu…
646899d 
…tter#103110)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@guidezpl @egramond
Add missing HIG links to cupertino documentation (flutter#103110)
c6b3a8e
@guidezpl guidezpl deleted the cupertino-hig-links branch May 8, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @TahaTesser