Skip to content

Improve Hero examples #103095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 6, 2022
Merged

Improve Hero examples #103095

fluttergithubbot merged 1 commit into from
May 6, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 4, 2022

I think it would be a good example for the audience if this were a separate stateless widget. It's more efficient that way, and helps with segmentation of the code.

Context: #102650 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 4, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 4, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@TahaTesser TahaTesser requested a review from gspencergoog May 4, 2022 22:17
@TahaTesser
Copy link
Member Author

TahaTesser commented May 4, 2022

@gspencergoog
If this looks good, I could request test exemption

@TahaTesser TahaTesser requested a review from guidezpl May 5, 2022 07:29
gspencergoog
gspencergoog approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog
Copy link
Contributor

gspencergoog commented May 5, 2022

Yes, this looks like a candidate for a test exemption. (refactor with no change in functionality)

@Hixie
Copy link
Contributor

Hixie commented May 6, 2022

test-exempt: code refactor with no semantic change

@fluttergithubbot fluttergithubbot merged commit cd6b2a3 into flutter:master May 6, 2022
@TahaTesser TahaTesser deleted the update_hero_examples branch May 6, 2022 06:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2022
@engine-flutter-autoroll
cd6b2a3 Improve Hero examples (flutter/flutter#103095)
12be34c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 6, 2022
@engine-flutter-autoroll
cd6b2a3 Improve Hero examples (flutter/flutter#103095)
8bac336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@guidezpl guidezpl Awaiting requested review from guidezpl

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos

Projects

Nevercode
Status: Done (PR merged)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TahaTesser @gspencergoog @Hixie @fluttergithubbot