DefaultTextEditingShortcuts should use meta-based shortcut for iOS #103077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
justinmc
approved these changes
May 5, 2022
| expect(MediaQuery.of(capturedContext), isNotNull); | ||
| }); | ||
|
|
||
| testWidgets('WidgetsApp provide meta based shortcut for iOS', (WidgetTester tester) async { |
| expect(selectAllSpy.invoked, isTrue); | ||
| expect(copySpy.invoked, isTrue); | ||
| expect(pasteSpy.invoked, isTrue); | ||
| }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS })); |
Contributor
There was a problem hiding this comment.
Nit: This should work identically for macOS, right? Should we just make this test about both platforms or is that misleading?
| break; | ||
|
|
||
| // Mac expands by line. | ||
| // Mac and iOS expands by line. |
Contributor
There was a problem hiding this comment.
In these comments that you changed here and below, the verb should be changed now that the subject is plural. So "expands" => "expand" in this case, etc.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #103073
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.