Skip to content

Add assertion that snackbars have a place to go #103006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 4, 2022
Merged

Add assertion that snackbars have a place to go #103006

fluttergithubbot merged 1 commit into from
May 4, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented May 4, 2022

This adds an assertion to ScaffoldMessenger.showSnackBar that makes sure the user will actually see the SnackBar. :)

Fixes #103004

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added f: material design flutter/packages/flutter/material repository. a: quality A truly polished experience a: error message Error messages from the Flutter framework labels May 4, 2022
@Piinks Piinks requested a review from craiglabenz May 4, 2022 00:26
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 4, 2022
craiglabenz
craiglabenz approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

packages/flutter/test/material/snack_bar_test.dart
home: Center(),
));

final ScaffoldMessengerState scaffoldMessengerState = tester.state<ScaffoldMessengerState>(
Copy link
Contributor

@craiglabenz craiglabenz May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen tester.state before!

@fluttergithubbot fluttergithubbot merged commit 122ab83 into flutter:master May 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 4, 2022
@engine-flutter-autoroll
122ab83 Add assertion that snackbars have a place to go (flutter/flut…
7a3e42b 
…ter#103006)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@Piinks @egramond
Add assertion that snackbars have a place to go (flutter#103006)
2a51e51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2022
@engine-flutter-autoroll
122ab83 Add assertion that snackbars have a place to go (flutter/flut…
724fd90 
…ter#103006)
Piinks added a commit that referenced this pull request May 5, 2022
@Piinks
Revert "Add assertion that snackbars have a place to go (#103006)"
984113c 
This reverts commit 122ab83.
This was referenced May 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craiglabenz craiglabenz craiglabenz approved these changes

Assignees

No one assigned

Labels

a: error message Error messages from the Flutter framework a: quality A truly polished experience f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScaffoldMessenger.showSnackBar doesn't check if there are any Scaffolds to present in

3 participants

@Piinks @craiglabenz @fluttergithubbot