Skip to content

rename local functions with _s #102991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 5, 2022
Merged

rename local functions with _s #102991

fluttergithubbot merged 1 commit into from
May 5, 2022

Conversation

@pq
Copy link
Contributor

@pq pq commented May 3, 2022 •
edited
Loading

rename local functions with _s

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See also: #102615. (This has crept in since then.)

And:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels May 3, 2022
@pq pq requested review from TahaTesser and goderbauer May 3, 2022 20:51
goderbauer
goderbauer approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 3, 2022

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot fluttergithubbot merged commit f771c9f into flutter:master May 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2022
@engine-flutter-autoroll
f771c9f rename local functions with _s (flutter/flutter#102991)
5450d4d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 5, 2022
@engine-flutter-autoroll
f771c9f rename local functions with _s (flutter/flutter#102991)
5b575a3
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@pq @egramond
rename local functions with _s (flutter#102991)
d6e4da7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@TahaTesser TahaTesser Awaiting requested review from TahaTesser

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @fluttergithubbot @goderbauer