partial revert of repaint boundary change #102962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
dnfield
approved these changes
May 3, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM. Consider adding a test here that would fail in the same way the internal one is.
Contributor
|
Are you sure the opacity changes aren't related to b/230173482? |
Contributor
Author
|
Yes, this wasn't a scuba issue actually it was an assert hit during a scuba test which broke the layout in a few. But nothing surfaces that because scuba is terrible |
CaseyHillers
approved these changes
May 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 3, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 6, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
May 6, 2022
#103214) Co-authored-by: Jonah Williams <[email protected]>
Contributor
Author
The internal test isn't even a test, its a scuba and completely worthless. /rant |
muditatandon
pushed a commit
to muditatandon/flutter
that referenced
this pull request
May 9, 2022
…#102962) (flutter#103214) Co-authored-by: Jonah Williams <[email protected]>
muditatandon
added a commit
that referenced
this pull request
May 9, 2022
…#103374) * [flutter_releases] Cherry pick flutter-2.13-candidate.7 changes (#103206) * Revert "Fix jumping when doing long press for selecting text (#102270)" (#103142) This reverts commit 6ea4aef. * Roll engine with Cps * Fix engine hash * [flutter_releases] partial revert of repaint boundary change (#102962) (#103214) Co-authored-by: Jonah Williams <[email protected]> * [flutter_releases] remove assert on markNeedsCompositingBitsUpdate #103227 (#103225) Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Jonah Williams <[email protected]>
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 16, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
May 16, 2022
* [flutter_releases] Roll engine to 2b14309d * remove assert on markNeedsCompositingBitsUpdate (#103227) * partial revert of repaint boundary change (#102962) * Revert "Fix jumping when doing long press for selecting text" (#103141) Co-authored-by: Jonah Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several scuba failures may be due to a bad interaction between this change and the visibility widget which uses Opacity. See https://buganizer.corp.google.com/issues/230559665