[flutter_tools] add --uninstall-first flag and pipe it through to ios-deploy #102948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
platform-ios
christopherfujino
force-pushed
the
add-uninstall-first-flag
branch
from
d4f7314 to
b396eb9
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This was referenced May 3, 2022
christopherfujino
force-pushed
the
add-uninstall-first-flag
branch
from
16609a3 to
1e06901
Compare
| '--no-android-gradle-daemon', | ||
| '--no-publish-port', | ||
| '--verbose', | ||
| '--uninstall-first', |
Contributor
Author
There was a problem hiding this comment.
this is the only non-formatting change here
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
approved these changes
May 6, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM with help text nit.
By the way it should be pretty trivial to get this working on Android if you pass uninstallFirst to installApp, then copy this logic to the top if it's true.
flutter/packages/flutter_tools/lib/src/android/android_device.dart
Lines 419 to 420 in 1bb9eed
Co-authored-by: Jenn Magder <[email protected]>
jmagman
approved these changes
May 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 9, 2022
Contributor
Author
|
Looks like this didn't work: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_ios%20hot_mode_dev_cycle_ios__benchmark/1342/overview This is the latest build, 2 days after this PR landed, and I can see that it is successfully uninstalling the app before running, and yet |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
ditman
added a commit
to ditman/flutter-packages
that referenced
this pull request
May 9, 2022
Roll Flutter from b305eb6 to 4c57320 (33 revisions) flutter/flutter@b305eb6...4c57320 2022-05-09 [email protected] Roll Flutter Engine from 71b9adccfb63 to 6248a5a9ae28 (1 revision) (flutter/flutter#103350) 2022-05-09 [email protected] Roll Flutter Engine from 3af7fb24d4dd to 71b9adccfb63 (1 revision) (flutter/flutter#103347) 2022-05-09 [email protected] [flutter_tools] stringArg refactor (flutter/flutter#103231) 2022-05-09 [email protected] Replace ListView with ListView.builder for LicensesPage (flutter/flutter#102692) 2022-05-09 [email protected] Adds `menuBarMenuLabel`, and removes unneeded key localizations (flutter/flutter#102100) 2022-05-09 [email protected] Roll Plugins from 49b06b3 to c5c319a (15 revisions) (flutter/flutter#103345) 2022-05-09 [email protected] Roll Engine from e7c44a582c58 to 3af7fb24d4dd (1 revision) (flutter/flutter#103334) 2022-05-09 [email protected] Roll Engine from c02712fe1160 to e7c44a582c58 (1 revision) (flutter/flutter#103333) 2022-05-09 [email protected] Roll Engine from 6efd8f00dcc6 to c02712fe1160 (1 revision) (flutter/flutter#103327) 2022-05-09 [email protected] `CupertinoTabScaffold`/`CupertinoTabController`: Add interactive examples (flutter/flutter#103196) 2022-05-09 [email protected] Roll Engine from c930e64a13bc to 6efd8f00dcc6 (1 revision) (flutter/flutter#103323) 2022-05-08 [email protected] Roll Engine from d0e6e14d27cc to c930e64a13bc (2 revisions) (flutter/flutter#103308) 2022-05-08 [email protected] Roll Engine from fffb3eb58e7d to d0e6e14d27cc (1 revision) (flutter/flutter#103307) 2022-05-08 [email protected] Use consistent date instead of DateTime.now() in evaluation tests (flutter/flutter#103269) 2022-05-08 [email protected] Roll Engine from 259ccadd8203 to fffb3eb58e7d (1 revision) (flutter/flutter#103298) 2022-05-08 [email protected] Roll Engine from 0b84783081a7 to 259ccadd8203 (1 revision) (flutter/flutter#103293) 2022-05-08 [email protected] Roll Engine from 19d5f037f221 to 0b84783081a7 (1 revision) (flutter/flutter#103291) 2022-05-08 [email protected] Roll Engine from 2d1f34cbdde2 to 19d5f037f221 (1 revision) (flutter/flutter#103289) 2022-05-08 [email protected] Roll Engine from b89e093d887f to 2d1f34cbdde2 (1 revision) (flutter/flutter#103287) 2022-05-08 [email protected] Roll Engine from aa80520b7fc9 to b89e093d887f (1 revision) (flutter/flutter#103286) 2022-05-08 [email protected] Roll Engine from 4c05cb763866 to aa80520b7fc9 (1 revision) (flutter/flutter#103283) 2022-05-07 [email protected] Roll Engine from 235d951ccfbd to 4c05cb763866 (1 revision) (flutter/flutter#103279) 2022-05-07 [email protected] Roll Engine from 24466845e7a9 to 235d951ccfbd (4 revisions) (flutter/flutter#103276) 2022-05-07 [email protected] Roll Engine from 2d2f8629cdb2 to 24466845e7a9 (1 revision) (flutter/flutter#103274) 2022-05-07 [email protected] Roll Engine from 4a358030cb07 to 2d2f8629cdb2 (1 revision) (flutter/flutter#103273) 2022-05-07 [email protected] [flutter_tools] add --uninstall-first flag and pipe it through to ios-deploy (flutter/flutter#102948) 2022-05-07 [email protected] Fix a `_WrappedScrollBehavior.shouldNotify` bug (flutter/flutter#103267) 2022-05-07 [email protected] Remove custom `unawaited`, prefer `dart:async` version (flutter/flutter#103212) 2022-05-07 [email protected] Added clipBehavior on TabBarView (flutter/flutter#103166) 2022-05-07 [email protected] Fix empty Stack with infinite constraints throws (flutter/flutter#102642) 2022-05-07 [email protected] Updating the Slider Widget to allow up and down arrow keys to navigate out of the slider when in directional NavigationMode. (flutter/flutter#103149) 2022-05-07 [email protected] Fix `DropdownButton` menu clip (flutter/flutter#102970) 2022-05-07 [email protected] Roll Engine from 094cb30943a5 to 4a358030cb07 (1 revision) (flutter/flutter#103260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully address #95582.
I ran the devicelab test locally and it removed the gallery app from my phone before installing it again.