Skip to content

Reland "Fix position of CupertinoContextMenu within Transform.scale" #102943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 2 commits into from
May 4, 2022
Merged

Reland "Fix position of CupertinoContextMenu within Transform.scale" #102943

guidezpl merged 2 commits into from
May 4, 2022

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented May 2, 2022

Relands #97896

Tests failed after merge as the file context_menu_test.dart had some methods renamed in another commit.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 2, 2022
@moffatman
Copy link
Contributor Author

moffatman commented May 2, 2022

@guidezpl Should not break the tree this time 👍

guidezpl
guidezpl approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@guidezpl guidezpl merged commit b5321d1 into flutter:master May 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 4, 2022
@engine-flutter-autoroll
b5321d1 Reland "Fix position of CupertinoContextMenu within Transform…
19a169b 
….scale" (flutter/flutter#102943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2022
@engine-flutter-autoroll
b5321d1 Reland "Fix position of CupertinoContextMenu within Transform…
3e5c3e1 
….scale" (flutter/flutter#102943)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@moffatman @egramond
Reland "Fix position of CupertinoContextMenu within Transform.scale" (f…
15e7ebb 
…lutter#102943)

* Fix position of CupertinoContextMenu within Transform.scale (flutter#97896)

* Fix after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moffatman @guidezpl