Repository navigation
Add option to customise data table sorting icon(#91801) - #102870
dheerajv09 wants to merge 4 commits into
Conversation
flutter-dashboard
Bot
added
p: material_ui
|
Hi @dheerajv09, thank you for your contribution! I think this is great, but what do you think about making the sorting icon a |
|
Hi, @Renzo-Olivares , can you tell what's all the failed check error means??. |
|
Looks like it might be unrelated. Try syncing your PR up to master. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| /// The icon to customize sorting icon in header. | ||
| /// | ||
| /// By default uses Icon(Icons.arrow_upward,size: 16.0) |
There was a problem hiding this comment.
| /// By default uses Icon(Icons.arrow_upward,size: 16.0) | |
| /// By default, this uses `Icon(Icons.arrow_upward, size: 16.0)`. |
| ..setTranslationRaw(0.0, _arrowIconBaselineOffset, 0.0), | ||
| alignment: Alignment.center, | ||
| child: const Icon( | ||
| child: widget.sortIcon ?? const Icon( |
There was a problem hiding this comment.
should this just be the default value of the constructor parameter for DataTable? That would make this a compile-time test rather than a runtime test.
|
@dheerajv09 Will you be able to continue working on this? It's totally fine if not; we can take it over (though it might take longer). I'm just asking because I'm trying to clean out our review queue. |
|
I'm going to close this PR for now to get it off our review queue, but please don't hesitate to submit a new PR if you have the time to get back to it. In the meantime I'll mention this PR on the issue so that anyone else who wants to pick it up can do so. Thanks again for your contribution! |
Adds option to add customized icon in place of default sorting icon.
fixes #91801