Skip to content

Revert "delete fast reassemble code" #102856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Apr 29, 2022
Merged

Revert "delete fast reassemble code" #102856

zanderso merged 1 commit into from
Apr 29, 2022

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Apr 29, 2022

Reverts #102842

@zanderso zanderso requested a review from jonahwilliams April 29, 2022 23:35
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 29, 2022
christopherfujino
christopherfujino approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonahwilliams
jonahwilliams approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 02b300d into master Apr 29, 2022
@zanderso zanderso deleted the revert-102842-remove_unused-debug-field branch April 29, 2022 23:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
02b300d Revert "delete fast reassemble code (#102842)" (flutter/flutt…
bb40073 
…er#102856)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 30, 2022
@engine-flutter-autoroll
02b300d Revert "delete fast reassemble code (#102842)" (flutter/flutt…
94194a6 
…er#102856)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@zanderso @egramond
Revert "delete fast reassemble code (flutter#102842)" (flutter#102856)
8c9d2b3 
This reverts commit ec8693e.
@goderbauer
Copy link
Member

goderbauer commented May 6, 2022

Could you please leave a quick note about WHY something was reverted in the PR description of a revert for people who later look at these and wonder why this failed? Thanks!

@zanderso
Copy link
Member Author

zanderso commented May 6, 2022

There were test failures on CI, for example: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20tool_integration_tests_4_4/4243/overview.

The rest are flagged on https://flutter-dashboard.appspot.com/#/build?taskFilter&authorFilter&messageFilter&hashFilter=ec8693e80bf2c9f31c06d9832ebb4bccc5274440&showMac=true&showWindows=true&showiOS=true&showLinux=true&showAndroid=true&showStaging=false&repo=flutter&branch=master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @goderbauer @christopherfujino @jonahwilliams