Skip to content

[devicelab, flutter_test, ...] rename local functions with _s #102833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 3, 2022
Merged

[devicelab, flutter_test, ...] rename local functions with _s #102833

fluttergithubbot merged 1 commit into from
May 3, 2022

Conversation

@pq
Copy link
Contributor

@pq pq commented Apr 29, 2022 •
edited
Loading

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See also:

This should be the last PR before https://dart-review.googlesource.com/c/sdk/+/242391 can land. 🤞

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 29, 2022
@pq pq requested a review from goderbauer April 29, 2022 17:55
goderbauer
goderbauer approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 29, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@pq pq mentioned this pull request Apr 30, 2022
Merged
@fluttergithubbot fluttergithubbot merged commit 20f029e into flutter:master May 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2022
@engine-flutter-autoroll
20f029e [devicelab, flutter_test, ...] rename local functions with `_…
6e47681 
…`s (flutter/flutter#102833)
@pq pq deleted the non_constant_identifier_names_moar branch May 3, 2022 18:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 3, 2022
@engine-flutter-autoroll
20f029e [devicelab, flutter_test, ...] rename local functions with `_…
573393a 
…`s (flutter/flutter#102833)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@pq @egramond
[devicelab, flutter_test, ...] rename local functions with _s (flut…
68a606e 
…ter#102833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @fluttergithubbot @goderbauer