Skip to content

Add Material 3 AppBar example #102823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
May 19, 2022
Merged

Add Material 3 AppBar example #102823

fluttergithubbot merged 4 commits into from
May 19, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 29, 2022 •
edited
Loading

part of #101048

Important

Merge this after #102697 is moved to stable since dartpad runs on stable.

Screen.Recording.2022-04-29.at.16.01.48.mov

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 29, 2022
@HansMuller HansMuller requested review from darrenaustin and removed request for gspencergoog April 29, 2022 19:06
@gspencergoog
Copy link
Contributor

gspencergoog commented May 4, 2022

Last I knew, dartpad doesn't run on stable, it runs on something like beta (a master build made in the last few weeks). That could have changed since I last checked though.

gspencergoog
gspencergoog requested changes May 4, 2022
View reviewed changes
packages/flutter/lib/src/material/app_bar.dart Outdated
Copy link
Contributor

@gspencergoog gspencergoog May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief description here?

Copy link
Member Author

@TahaTesser TahaTesser May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

packages/flutter/lib/src/material/app_bar.dart Outdated
Copy link
Contributor

@gspencergoog gspencergoog May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that this is the correct link, depending on the description you added above.

Copy link
Member Author

@TahaTesser TahaTesser May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all 3 examples, thank you!

@TahaTesser TahaTesser force-pushed the m3_app_bar_example branch from 0ef546d to e831d2b Compare May 13, 2022 13:26
@TahaTesser TahaTesser removed the request for review from guidezpl May 13, 2022 13:32
@TahaTesser
Copy link
Member Author

TahaTesser commented May 13, 2022

  • Last I knew, dartpad doesn't run on stable, it runs on something like beta (a master build made in the last few weeks). That could have changed since I last checked though.

I filed this PR to be merged after #102697
Looks like the M3 AppBar has now landed in the stable channel #102697 (comment)

I also just confirmed the M3 example by running on the stable API docs.
https://api.flutter.dev/flutter/material/AppBar-class.html

Screen.Recording.2022-05-13.at.16.39.48.mov

@TahaTesser TahaTesser requested a review from gspencergoog May 13, 2022 13:41
gspencergoog
gspencergoog approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@TahaTesser
Material 3: Add AppBar example
4b183a2 
fixes

fix analyzer issue

Optimize spacing for dartpad window size
@TahaTesser TahaTesser force-pushed the m3_app_bar_example branch from 2abaeb0 to 4b183a2 Compare May 16, 2022 18:42
@TahaTesser TahaTesser force-pushed the m3_app_bar_example branch from 9e352e9 to c9bfa4c Compare May 17, 2022 15:54
TahaTesser added 2 commits May 18, 2022 11:10
@TahaTesser
Update super
3efc0f2
@TahaTesser
Merge branch 'master' of github.com:flutter/flutter into m3_app_bar_e…
cc3f0d6 
…xample

# Conflicts:
#	examples/api/lib/material/app_bar/app_bar.0.dart
#	examples/api/lib/material/app_bar/app_bar.1.dart
#	examples/api/lib/material/app_bar/sliver_app_bar.1.dart
@TahaTesser TahaTesser force-pushed the m3_app_bar_example branch from c9bfa4c to cc3f0d6 Compare May 18, 2022 08:13
@fluttergithubbot fluttergithubbot merged commit 3f5bd7d into flutter:master May 19, 2022
@TahaTesser TahaTesser deleted the m3_app_bar_example branch May 19, 2022 07:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2022
@engine-flutter-autoroll
3f5bd7d Add Material 3 AppBar example (flutter/flutter#102823)
66052cb
@guidezpl guidezpl mentioned this pull request May 19, 2022
Closed
7 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
3f5bd7d Add Material 3 AppBar example (flutter/flutter#102823)
a4f5cbe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
3f5bd7d Add Material 3 AppBar example (flutter/flutter#102823)
b671ca4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
3f5bd7d Add Material 3 AppBar example (flutter/flutter#102823)
7cc03e2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3f5bd7d Add Material 3 AppBar example (flutter/flutter#102823)
962b966
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3f5bd7d Add Material 3 AppBar example (flutter/flutter#102823)
e3553e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @gspencergoog @fluttergithubbot