Skip to content

Adds RouterConfig to simply API #102786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 6 commits into from
Apr 30, 2022
Merged

Adds RouterConfig to simply API #102786

fluttergithubbot merged 6 commits into from
Apr 30, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 28, 2022

fixes #101386

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels Apr 28, 2022
chunhtai
chunhtai commented Apr 28, 2022
View reviewed changes
packages/flutter/lib/src/widgets/router.dart Outdated
Copy link
Contributor Author

@chunhtai chunhtai Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A router can be restored with just routerDelegate

Copy link
Contributor Author

@chunhtai chunhtai Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that cases, there is really nothing need to be restored because all the state will be in the routerDelegate

@chunhtai chunhtai requested a review from goderbauer April 28, 2022 22:40
goderbauer
goderbauer approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 29, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit f86d108 into flutter:master Apr 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2022
@engine-flutter-autoroll
f86d108 Adds RouterConfig to simply API (flutter/flutter#102786)
3267657
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 30, 2022
@engine-flutter-autoroll
f86d108 Adds RouterConfig to simply API (flutter/flutter#102786)
e66db3e
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@chunhtai @egramond
Adds RouterConfig to simply API (flutter#102786)
6baf01e
@GutsGo GutsGo mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MaterialApp.router and friends should take a (single) RouterConfig object for ease-of-use

3 participants

@chunhtai @fluttergithubbot @goderbauer