Skip to content

Update features.dart #102766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 28, 2022
Merged

Update features.dart #102766

fluttergithubbot merged 2 commits into from
Apr 28, 2022

Conversation

@timsneath
Copy link
Contributor

@timsneath timsneath commented Apr 28, 2022 •
edited
Loading

Match text across desktop versions.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Update features.dart
b7b4c37 
Match across desktop versions
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 28, 2022
@timsneath timsneath requested a review from cbracken April 28, 2022 15:54
cbracken
cbracken approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for spotting!

Update features_test.dart
703865c 
Fix tests to match change.
@fluttergithubbot fluttergithubbot merged commit e4bd552 into master Apr 28, 2022
@fluttergithubbot fluttergithubbot deleted the timsneath-remove-extrahelp branch April 28, 2022 23:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
e4bd552 Update features.dart (flutter/flutter#102766)
5126038
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
e4bd552 Update features.dart (flutter/flutter#102766)
69b96dc
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@egramond
Update features.dart (flutter#102766)
d3316db
godofredoc added a commit that referenced this pull request May 26, 2022
@godofredoc @christopherfujino
[flutter_releases] Flutter beta 3.1.0 Framework Cherrypicks (#104663)
bcea432 
* [flutter_tools] update feature defaults (#102937)

* 'Create candidate branch version flutter-2.13-candidate.5 for beta'

* 'Update Engine revision to 44e5b38ee83a1282981a30abc08ffcf6cd0e44bd for beta release 3.1.0'

* Update features.dart (#102766)

* Remove armv7 codesigning.

Co-authored-by: Christopher Fujino <[email protected]>
Co-authored-by: Tim Sneath <[email protected]>
@omidkarami77 omidkarami77 mentioned this pull request Jun 29, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timsneath @cbracken @fluttergithubbot