Skip to content

ReorderableListView: fix broken dartpad example & update examples, add tests #102723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 28, 2022
Merged

ReorderableListView: fix broken dartpad example & update examples, add tests #102723

fluttergithubbot merged 2 commits into from
Apr 28, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 28, 2022 •
edited
Loading

API: https://master-api.flutter.dev/flutter/material/ReorderableListView-class.html

fixes #102724

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 28, 2022
@TahaTesser TahaTesser requested a review from gspencergoog April 28, 2022 07:16
@TahaTesser TahaTesser changed the title ReorderableListView: fix broken dartpad example ReorderableListView: fix broken dartpad example & update examples, add tests Apr 28, 2022
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 28, 2022
HansMuller
HansMuller approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see functionality tests here.

LGTM

@HansMuller HansMuller removed the request for review from gspencergoog April 28, 2022 15:37
@fluttergithubbot fluttergithubbot merged commit b1f88a6 into flutter:master Apr 28, 2022
@TahaTesser TahaTesser deleted the fix-ReorderableListView-example branch April 28, 2022 17:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
b1f88a6 ReorderableListView: fix broken dartpad example & update ex…
2834a27 
…amples, add tests (flutter/flutter#102723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
b1f88a6 ReorderableListView: fix broken dartpad example & update ex…
2474e6b 
…amples, add tests (flutter/flutter#102723)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@TahaTesser @egramond
ReorderableListView: fix broken dartpad example & update examples, …
b5a7f6e 
…add tests (flutter#102723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix ReorderableListView dart example tag and update existing examples, add tests

3 participants

@TahaTesser @HansMuller @fluttergithubbot