Skip to content

[dev, bots, examples] rename local functions with _s #102703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 28, 2022
Merged

[dev, bots, examples] rename local functions with _s #102703

fluttergithubbot merged 1 commit into from
Apr 28, 2022

Conversation

@pq
Copy link
Contributor

@pq pq commented Apr 28, 2022 •
edited
Loading

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See also:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq
rename local functions with _s
358cb61 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.
@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 28, 2022
@pq pq requested a review from goderbauer April 28, 2022 00:58
goderbauer
goderbauer approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 28, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 80849ad into flutter:master Apr 28, 2022
@pq pq deleted the non_constant_identifier_names_dev branch April 28, 2022 17:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
80849ad [dev, bots, examples] rename local functions with _s (flutt…
b8361f5 
…er/flutter#102703)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
80849ad [dev, bots, examples] rename local functions with _s (flutt…
34ee9e7 
…er/flutter#102703)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@pq @egramond
[dev, bots, examples] rename local functions with _s (flutter#102703)
214247d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @fluttergithubbot @goderbauer