Skip to content

[flutter_tools] rename local functions with _s #102688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 27, 2022
Merged

[flutter_tools] rename local functions with _s #102688

fluttergithubbot merged 1 commit into from
Apr 27, 2022

Conversation

@pq
Copy link
Contributor

@pq pq commented Apr 27, 2022 •
edited
Loading

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See also:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq
rename local functions with _s
c94607c 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.
@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 27, 2022
@pq pq changed the title rename local functions with _s [flutter_tools] rename local functions with _s Apr 27, 2022
@pq pq requested a review from goderbauer April 27, 2022 20:55
goderbauer
goderbauer approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit b5e7fb0 into flutter:master Apr 27, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
b5e7fb0 [flutter_tools] rename local functions with _s (flutter/flu…
6d87f5a 
…tter#102688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
b5e7fb0 [flutter_tools] rename local functions with _s (flutter/flu…
9e8fe4c 
…tter#102688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
b5e7fb0 [flutter_tools] rename local functions with _s (flutter/flu…
a35d026 
…tter#102688)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@pq @egramond
[flutter_tools] rename local functions with _s (flutter#102688)
6d67f29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @goderbauer @fluttergithubbot