Skip to content

Hero: Add an example for createRectTween #102650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Apr 29, 2022
Merged

Hero: Add an example for createRectTween #102650

fluttergithubbot merged 4 commits into from
Apr 29, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 27, 2022 •
edited
Loading

fixes #100903

Screen.Recording.2022-04-29.at.11.46.15.mov

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 27, 2022
@TahaTesser TahaTesser requested a review from gspencergoog April 27, 2022 14:12
@TahaTesser TahaTesser changed the title Hero: Add an example createRectTween Hero: Add an example for createRectTween Apr 27, 2022
@TahaTesser TahaTesser force-pushed the hero_rect_tween_example branch from 94a09b1 to 8c3386e Compare April 27, 2022 14:16
@goderbauer
Copy link
Member

goderbauer commented Apr 27, 2022

Looks like some checks are unhappy with this PR.

@TahaTesser TahaTesser force-pushed the hero_rect_tween_example branch from 8c3386e to 5cfb04c Compare April 27, 2022 22:14
goderbauer
goderbauer reviewed Apr 28, 2022
View reviewed changes
@TahaTesser TahaTesser requested a review from goderbauer April 28, 2022 19:02
goderbauer
goderbauer approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser removed the request for review from gspencergoog April 29, 2022 09:32
goderbauer
goderbauer approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
Copy link
Member Author

TahaTesser commented Apr 29, 2022

@goderbauer
Thanks so much for an amazing review!

@fluttergithubbot fluttergithubbot merged commit eef4aa7 into flutter:master Apr 29, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
eef4aa7 Hero: Add an example for createRectTween (flutter/flutter…
7d4fe20 
…#102650)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
eef4aa7 Hero: Add an example for createRectTween (flutter/flutter…
ab33b41 
…#102650)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
eef4aa7 Hero: Add an example for createRectTween (flutter/flutter…
114f19a 
…#102650)
@TahaTesser TahaTesser deleted the hero_rect_tween_example branch May 3, 2022 06:18
gspencergoog
gspencergoog reviewed May 4, 2022
View reviewed changes
@TahaTesser TahaTesser mentioned this pull request May 4, 2022
Merged
8 tasks
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@TahaTesser @egramond
Hero: Add an example for createRectTween (flutter#102650)
be8c5e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog left review comments

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@nilsreichardt nilsreichardt nilsreichardt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Image in Hero animation is displayed outside the borders

5 participants

@TahaTesser @goderbauer @gspencergoog @nilsreichardt @fluttergithubbot