Skip to content

rename local functions with _s #102615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pq merged 1 commit into from
Apr 27, 2022
Merged

rename local functions with _s #102615

pq merged 1 commit into from
Apr 27, 2022

Conversation

@pq
Copy link
Contributor

@pq pq commented Apr 27, 2022 •
edited
Loading

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See: https://dart-review.googlesource.com/c/sdk/+/242391
See: dart-lang/sdk#58715

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Apr 27, 2022
@pq pq requested a review from goderbauer April 27, 2022 00:13
@pq pq mentioned this pull request Apr 27, 2022
Merged
8 tasks
goderbauer
goderbauer approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the cleanup!

@pq pq merged commit bca0718 into flutter:master Apr 27, 2022
@pq pq deleted the non_constant_identifier_names_flutter branch April 27, 2022 16:15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
12811c0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
75d7673
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
21c8c4b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
9f294a8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
0aa478f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
5a685e2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
a1f644e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
32ccd86
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
721da31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
6fb7f86
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
11f3719
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
d68bdfc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
1eae962
@pq pq mentioned this pull request Apr 27, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
fe2f12d
This was referenced Apr 27, 2022
Merged
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
41a3d02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
c417d39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
bca0718 rename local functions with _s (flutter/flutter#102615)
d1d73c5
This was referenced Apr 29, 2022
Merged
Merged
Merged
Merged
@dkwingsmt dkwingsmt mentioned this pull request May 4, 2022
Merged
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@pq @egramond
rename local functions with _s (flutter#102615)
0c5dfc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pq @goderbauer