Skip to content

add missing trailing commas in list/set/map literals #102585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a14n merged 1 commit into from
Apr 27, 2022
Merged

add missing trailing commas in list/set/map literals #102585

a14n merged 1 commit into from
Apr 27, 2022

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Apr 26, 2022

In dart-archive/linter#3340 we will add lints on missing trailing commas in list/set/map literals. This PR fixes those new diagnostics.

@a14n a14n requested a review from Piinks as a code owner April 26, 2022 16:59
@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 26, 2022
@a14n a14n force-pushed the trailing_commas_in_literals branch from 8176b2c to fb33000 Compare April 26, 2022 17:08
@a14n a14n mentioned this pull request Apr 26, 2022
Merged
goderbauer
goderbauer approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

I did not review every single line, but the spot checks I did all looked reasonable.

@a14n a14n force-pushed the trailing_commas_in_literals branch from fb33000 to ff2f065 Compare April 26, 2022 18:58
@a14n a14n merged commit 07f1c20 into flutter:master Apr 27, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
93940c7 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
cf5a179 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
974696d 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
e5fdc9c 
…/flutter#102585)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
21f2e2e 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
115d64a 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
f72e0ba 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
aa1afaa 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
d591bf9 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
9687001 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
ebeb1ea 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
09ec8fc 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
4ff92fd 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
e9c07ff 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
98477f2 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
c183a7f 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
5902c8e 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
1a2434e 
…/flutter#102585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
07f1c20 add missing trailing commas in list/set/map literals (flutter…
686f8ba 
…/flutter#102585)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@a14n @egramond
add missing trailing commas in list/set/map literals (flutter#102585)
7297059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a14n @goderbauer