Fix AppBar scrolledUnder initial state - the third #102582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
Piinks
commented
Apr 27, 2022
|
|
||
| void _handleScrollNotification(ScrollNotification notification) { | ||
| if (notification is ScrollUpdateNotification) { | ||
| if (notification is ScrollUpdateNotification && notification.depth == 0) { |
Contributor
Author
There was a problem hiding this comment.
This is the change from the revert. If there are additional scroll views nested below, they could inaccurately change scrolled under to false, while the outer, main scroll view is actually scrolled under.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 28, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original change #101460
Reverted in #101929
Fixes #101416 (again) 🙂
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.