Skip to content

[macOS] Adds macOS project files to layers example #102539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
May 13, 2022
Merged

[macOS] Adds macOS project files to layers example #102539

cbracken merged 1 commit into from
May 13, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 26, 2022 •
edited
Loading

Adds macOS support to the layers examples collection.

Issue: #84306

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 26, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 26, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cbracken cbracken force-pushed the add-macos-projects branch from fa14e1e to ca4dfdc Compare April 26, 2022 00:58
@cbracken cbracken changed the title [macOS] Adds macOS project files to examples [macOS] Adds macOS project files to layers example Apr 26, 2022
@cbracken cbracken added platform-mac Building on or for macOS specifically a: desktop Running on desktop and removed work in progress; do not review labels Apr 26, 2022
jmagman
jmagman reviewed Apr 26, 2022
View reviewed changes
jmagman
jmagman reviewed Apr 26, 2022
View reviewed changes
@cbracken cbracken force-pushed the add-macos-projects branch from 9837228 to e18528b Compare April 26, 2022 01:36
@Hixie
Copy link
Contributor

Hixie commented Apr 26, 2022

test-exempt: configuration change

@cbracken
Copy link
Member Author

cbracken commented Apr 27, 2022

@jmagman looks like some examples have .metadata files checked in but others don't. I'm not super familiar with how they're used but I'm assuming by fix/migrate tooling, so may be useful to add?

@jmagman
Copy link
Member

jmagman commented Apr 27, 2022

@jmagman looks like some examples have .metadata files checked in but others don't. I'm not super familiar with how they're used but I'm assuming by fix/migrate tooling, so may be useful to add?

It's small can't hurt. Soon to be used by the new flutter migrate command. #102598

@cbracken cbracken force-pushed the add-macos-projects branch from e18528b to c5a9635 Compare May 13, 2022 18:04
@cbracken
Copy link
Member Author

cbracken commented May 13, 2022

This PR slipped my mine for a couple weeks. Icons removed and .metadata added. @jmagman PTAL.

jmagman
jmagman approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken force-pushed the add-macos-projects branch from c5a9635 to 6bc24a1 Compare May 13, 2022 18:15
@cbracken
[macOS] Adds macOS project files to layers example
e1f54d9 
Adds macOS support to the layers examples collection.

Issue: flutter#84306
@cbracken cbracken force-pushed the add-macos-projects branch from 6bc24a1 to e1f54d9 Compare May 13, 2022 18:19
@cbracken cbracken merged commit b04bdd0 into flutter:master May 13, 2022
@cbracken cbracken deleted the add-macos-projects branch May 13, 2022 21:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
2a75ec0 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
a99ae05 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
aa44534 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
707ee12 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
ee9a0b3 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
4e4e51e 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
e813919 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
4d3de1b 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
47ac35a 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
3e2bd11 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
d373ab0 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
d5ae9e0 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
c53511a 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
88ad88b 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
c2646c1 
…lutter#102539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
6912acb 
…lutter#102539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
4d18b90 
…lutter#102539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b04bdd0 [macOS] Adds macOS project files to layers example (flutter/f…
d562e1a 
…lutter#102539)
@darshankawar darshankawar mentioned this pull request Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-mac Building on or for macOS specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @Hixie @jmagman