Show custom error message when Kotlin or Gradle bump is required #102421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
blasten
force-pushed
the
gradle_error_messages
branch
from
38d9505 to
d13e005
Compare
added 2 commits
April 22, 2022 18:28
Author
|
PTAL @GaryQian |
Contributor
|
friendly ping @GaryQian |
GaryQian
approved these changes
May 6, 2022
| '${globals.logger.terminal.warningMark} Your project needs to upgrade Gradle and the Android Gradle plugin.\n\n' | ||
| 'To fix this issue, replace the following content:\n' | ||
| '${gradleFile.path}:\n' | ||
| ' ${globals.terminal.color("- classpath 'com.android.tools.build:gradle:<current-version>'", TerminalColor.red)}\n' |
Contributor
There was a problem hiding this comment.
Nit: Using <current-version> may mislead dev to search for specifically this string since it is presented as a +- diff. But i don't really see any obviously better way to display it.
Contributor
|
@blasten is this one ready to merge? |
blasten
added
waiting for PR to land (fixed)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows custom error messages when a bump of Kotlin or Gradle is required.
Once the migration tool is available, we can tell folks to run it to find more mismatches.