Revert "Clipping if only one character text overflows (#99146)" (#102… #102389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
flutter-dashboard
bot
added
a: text input
Member
|
Wasn't this already reverted in #102092? |
Member
|
Oh, this is for the candidate branch. Not sure what the process is, should we instead cherry-pick the revert in? |
goderbauer
approved these changes
Apr 22, 2022
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM assuming that this is preferred over cherry-picking the revert from #102092.
Contributor
Author
CaseyHillers
approved these changes
Apr 22, 2022
XilaiZhang
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…092)
CP: 8817521
This reverts commit 08e467d (Google test failures after merge).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.