Skip to content

Re-land reverse case for AppBar scrolled under #102343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 13 commits into from
Apr 25, 2022
Merged

Re-land reverse case for AppBar scrolled under #102343

fluttergithubbot merged 13 commits into from
Apr 25, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 21, 2022

Requires #102339 to land first and then double check against internal tests again.

Original change #101460
Reverted in #101929
Fixes #101416 (again) 🙂

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. labels Apr 21, 2022
@Piinks Piinks requested a review from darrenaustin April 21, 2022 22:53
darrenaustin
darrenaustin approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Piinks
Copy link
Contributor Author

Piinks commented Apr 25, 2022

@darrenaustin can you take another look? I changed the approach here.

Piinks
Piinks commented Apr 25, 2022
View reviewed changes
darrenaustin
darrenaustin approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an area that am really familiar with, but it LGTM. Thx.

@fluttergithubbot fluttergithubbot merged commit 5580164 into flutter:master Apr 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
4ba1c52 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
012110e 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
11f7332 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
f0f5bc9 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
185cb98 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
a024148 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
998e7e7 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
18e5f8f 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
d4a6616 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
6d1724f 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
e977c76 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
6a2dc0e 
…er#102343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
94831dd 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
fe297f4 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
2aa10b5 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
2a50a14 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
110c6e1 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
a4d13e7 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
1059d28 
…er#102343)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
5580164 Re-land reverse case for AppBar scrolled under (flutter/flutt…
642414d 
…er#102343)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@Piinks @egramond
Re-land reverse case for AppBar scrolled under (flutter#102343)
da8b018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xu-baolin xu-baolin xu-baolin left review comments

+1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AppBar with reversed scrollable doesn't properly indicate scrolledUnder state

4 participants

@Piinks @darrenaustin @xu-baolin @fluttergithubbot