Skip to content

Remove build_aar_module_test from devicelab tests #102329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 21, 2022
Merged

Remove build_aar_module_test from devicelab tests #102329

fluttergithubbot merged 1 commit into from
Apr 21, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Apr 21, 2022 •
edited
Loading

Fixes #102318

These tests don't need a device.
I plan to move this test to the tool's integration shard.

@blasten blasten requested a review from keyonghan as a code owner April 21, 2022 20:19
@blasten blasten mentioned this pull request Apr 21, 2022
Closed
keyonghan
keyonghan approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan mentioned this pull request Apr 21, 2022
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 21, 2022

This pull request is not suitable for automatic merging in its current state.

  • This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@blasten blasten force-pushed the remover_build_aar branch from 7cd804c to 11da07c Compare April 21, 2022 21:22
gspencergoog
gspencergoog approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

christopherfujino
christopherfujino approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 4ca94ab into flutter:master Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
3eefd2c 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
4dc6f87 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
7bf8f19 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
d2d473e 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
c90280f 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
bc7f569 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
0365328 
…utter#102329)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
11a477e 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
d18f943 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
e6b3ba5 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
3e560f6 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
03f4770 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
5069f5b 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
27b8ee0 
…utter#102329)
@christopherfujino christopherfujino mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
0203502 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
0888868 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
50e88bb 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
7b87aac 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
199533c 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
7e1ac66 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
9ae90a1 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
3496092 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
15e6fc2 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
85e8f6d 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
c95988a 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
6c7fec5 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
ff09487 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
fa13d5a 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
9ce5ebd 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
0b689ee 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
706dae2 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
b0e26b4 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
e742d3d 
…utter#102329)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
4ca94ab Remove build_aar_module_test from devicelab tests (flutter/fl…
1255c00 
…utter#102329)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@egramond
Remove build_aar_module_test from devicelab tests (flutter#102329)
1290bf5
@keyonghan keyonghan mentioned this pull request May 16, 2022
Closed
@gmackall gmackall mentioned this pull request Sep 10, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

+2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux build_aar_module_test has been flaky consistently

5 participants

@blasten @fluttergithubbot @christopherfujino @gspencergoog @keyonghan