Skip to content

Put waitFor back in keyboard_textfield_test integration test #102315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 21, 2022
Merged

Put waitFor back in keyboard_textfield_test integration test #102315

fluttergithubbot merged 2 commits into from
Apr 21, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Apr 21, 2022 •
edited
Loading

The thing the caused the timeout in the past during the driver.waitFor call in the keyboard_textfield_test integration test might have been the blinking cursor. Without runUnsynchronized waitFor won't find the target widget until all animations are stopped. I'll revert this if it makes the test flaky again.

Related Issue
#96787

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 21, 2022
jmagman
jmagman approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might have been the blinking cursor

Oh interesting theory! Let's try it.

@fluttergithubbot fluttergithubbot merged commit 06314a0 into flutter:master Apr 21, 2022
@LongCatIsLooong LongCatIsLooong deleted the textfield-test-switch-back-to-waitFor branch April 21, 2022 20:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
4f03207 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
9e09e20 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
ebcc883 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
878993c 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
a868cf5 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
426eae1 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
39061af 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
45193f8 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
00732a7 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
e8b5243 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
0f46162 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
9f11a80 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
884c398 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
ab1c1a4 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
44b8841 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
52612b8 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
7cffc40 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
673ae7c 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
1ede826 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
e315838 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
2683c37 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
7f93733 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
74f4582 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
cc9c398 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
047919b 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
8c5d324 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
8173ce4 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
a70de96 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
449281f 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
773b305 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
e4ecdc4 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
1b8902e 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
eb364c3 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
2f9b300 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
78b0c45 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
39bbc4b 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
5545ebc 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
39dc1f3 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
36b6d67 
flutter/flutter#102315)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@LongCatIsLooong @egramond
Put waitFor back in keyboard_textfield_test integration test (flutt…
afa9c0c 
…er#102315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @jmagman @fluttergithubbot