Skip to content

Revert "Fix reverse cases for App Bar scrolled under behavior (#10146… #102264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 1 commit into from
Apr 21, 2022
Merged

Revert "Fix reverse cases for App Bar scrolled under behavior (#10146… #102264

godofredoc merged 1 commit into from
Apr 21, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 20, 2022

CP: ea26272

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 20, 2022

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Apr 20, 2022
@Piinks
Copy link
Contributor

Piinks commented Apr 20, 2022 •
edited
Loading

LGTM, there is an analyzer issue though from a separate change

@Piinks @godofredoc
Revert "Fix reverse cases for App Bar scrolled under behavior (#101460)…
a115abe 
…" (#101929)

merging now since it blocks flutter roll for too long
@godofredoc godofredoc merged commit a8362dc into flutter:flutter-2.13-candidate.2 Apr 21, 2022
@godofredoc godofredoc deleted the flutter-2.13-candidate.2 branch April 21, 2022 16:51
@godofredoc godofredoc restored the flutter-2.13-candidate.2 branch April 21, 2022 16:51
@godofredoc godofredoc deleted the flutter-2.13-candidate.2 branch April 21, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @Piinks