Skip to content

[flutter_tools] remove UWP tooling #102174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 26, 2022
Merged

[flutter_tools] remove UWP tooling #102174

fluttergithubbot merged 2 commits into from
Apr 26, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 19, 2022 •
edited
Loading

Work towards #102172

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 19, 2022
@jonahwilliams jonahwilliams marked this pull request as ready for review April 19, 2022 23:17
cbracken
cbracken approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but please hold off landing till we've checked in with @zanderso.

@cbracken
Copy link
Member

cbracken commented Apr 26, 2022

@jonahwilliams

You're all clear kid, now let's blow this thing and go home!

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Apr 26, 2022

akq5YT.mp4

@fluttergithubbot fluttergithubbot merged commit 944fcda into flutter:master Apr 26, 2022
@jonahwilliams jonahwilliams deleted the remove_uwp_tooling branch April 26, 2022 18:20
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Apr 26, 2022

image

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
bb63e76
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
fef854d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
6fe10ef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
5d2221f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
87f7516
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
0e225d5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
4b99cbf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
189333d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
ad30240
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
edc0edb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
4144864
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
7fbd84d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
c846797
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
69798f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
527e19a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
c8fcd13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
893dc25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
86e6364
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
0b5b0f7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
d14fce2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
8d50d7b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
944fcda [flutter_tools] remove UWP tooling (flutter/flutter#102174)
37fd29f
This was referenced Apr 29, 2022
Merged
Merged
cbracken added a commit to flutter/engine that referenced this pull request Apr 30, 2022
@cbracken
WinUWP: Remove WinUWP sources, targets (#33019)
433de86 
This removes:
* The Windows UWP emebedder sources and targets
* UWP-specific build targets
* UWP-specific code behind WINUWP #ifdefs
* UWP-specific TODOs.
* uwptool.exe sources and targets used for installing, uninstalling, and
  launching UWP apps.

This is a straight removal patch, and does not land any refactorings
made possible by removal of UWP support. Those patches will land in
followup refactorings.

Tool support was removed in:
flutter/flutter#102174

The CI target was removed in:
#33012

The Recipe was removed in:
https://flutter-review.googlesource.com/c/recipes/+/29500

GN build support was removed in:
#33016

Issue: flutter/flutter#102172
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@egramond
[flutter_tools] remove UWP tooling (flutter#102174)
7871b6a
andreadaoud added a commit to andreadaoud/flutter-elinux that referenced this pull request Aug 21, 2022
@andreadaoud
elinux_device_discovery: remove UWP support
7470318 
UWP support is removed in flutter/flutter#102174,
so delete it to avoid compile error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @cbracken @fluttergithubbot