[reland] Migrate ListTile TextTheme TextStyle references to Material 3
#102167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
8 tasks
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
This looks reasonable. I am curious where the M3 values were coming from. I don't see them anywhere in the spec on https://m3.material.io/. Or is this just migrating from the old M2 textTheme names to the equivalent M3 names?
darrenaustin
approved these changes
May 25, 2022
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
It does indeed look like you were just updating the TextTheme style names that are being used. LGTM. Thx.
TahaTesser
force-pushed
the
reland_m3_list_tile_text
branch
from
0696642 to
1f24d1b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 25, 2022
8 tasks
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relands #101900 with
useMaterial3conditionfixes #102075
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.