Updating the Slider Widget to allow up and down arrow keys to navigate out of the slider. #102116
Conversation
flutter-dashboard
bot
added
f: material design
| // Keyboard mapping for a focused slider. | ||
| final Map<ShortcutActivator, Intent> _shortcutMap = const <ShortcutActivator, Intent>{ | ||
| final Map<ShortcutActivator, Intent> _traditionalNavShortcutMap = const <ShortcutActivator, Intent>{ | ||
| SingleActivator(LogicalKeyboardKey.arrowUp): _AdjustSliderIntent.up(), |
There was a problem hiding this comment.
Are we sure that these are even correct? I mean, it's convenient to have up and down change the slider, but are they actually idioms that anyone knows about? I can see it being important for a vertical slider, but we don't have those.
Because if they're not really idiomatic, then we can just eliminate them and directional nav will just work.
There was a problem hiding this comment.
I don't know the history behind that particular bit of functionality so I went with the solution that affects the least amount of things. I'd be happy to switch to that smaller change if you think it's safe.
egramond
changed the title
|
cc @clocksmith who initially added keyboard shortcut support to the Slider Widget and may know if the up and down shortcuts are idiomatic for some use cases. |
egramond
changed the title
In preparation for upgrading linux VMs to Ubuntu, specify builders to use 'os: Debian' instead of 'os: Linux'. There should be no functional changes to current builders with this change. Bug:102252
… all the inner children layers (flutter#102309)
* Change dependency name to apple_signing for a better understanding of it's use * Updated Mac_ios test to run if .ci.yaml is updated
…lutter#102943) * Fix position of CupertinoContextMenu within Transform.scale (flutter#97896) * Fix after rebase
…102808) * Add prominent link to google fonts from icons * Update icons.dart * Update icons.dart
…" (flutter#103074) This reverts commit 74e9a6d.
egramond
requested review from
Piinks,
christopherfujino,
jmagman and
keyonghan
as code owners
|
ok so I screwed up this PR beyond repair with some git upstream command. I'll start a fresh one. |
|
We've all been there. :-) Just let me know what the new one is and I'll review it. |
20 participants
Updating Slider Widget to allow up and down arrow keys to navigate out of the slider on directional navigation mode.
This prevents users using directional navigation from becoming stuck on the slider once they navigate to it.