Removed required from deprecated API #102107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
c: contributor-productivity
flutter-dashboard
bot
added
the
f: material design
darrenaustin
approved these changes
Apr 18, 2022
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
Nice cleanup. LGTM!
Member
|
Maybe there should be a lint to warn you that |
Contributor
Author
I think that is in progress in dart-lang/sdk#48206 |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
This'll take a little bit more work, looking at internal broken customers. I think I can just add a getter that unwraps the now nullable parameter to satisfy those. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 19, 2022
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the required keyword from deprecated API in the Flutter framework
It does not make sense to require folks to use deprecated API, when they should be migrating to the new code.
Fixes #102106
Related to dart-lang/sdk#48206
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.