Fix Backbutton is not displayed when there is a endDrawer #102093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
chunhtai
commented
Apr 18, 2022
Contributor
Author
There was a problem hiding this comment.
I think this should default to false, but i made it true for backward compatibility
Contributor
Author
|
This change will require a internal fix, since some of the internal test still relies on willHandlePopInternally to bring up the backbutton |
Contributor
Author
|
a friendly bump |
dnfield
approved these changes
Apr 21, 2022
chunhtai
force-pushed
the
issues/80256-reland
branch
from
9776926 to
dbe3b42
Compare
chunhtai
force-pushed
the
issues/80256-reland
branch
from
dbe3b42 to
fdd087a
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2022
8 tasks
chunhtai
pushed a commit
that referenced
this pull request
May 18, 2022
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 18, 2022
…utter#102093)" (flutter#104039) This reverts commit f8f4387.
CaseyHillers
pushed a commit
that referenced
this pull request
May 18, 2022
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
May 18, 2022
…utter#102093)" This reverts commit a4a8e73.
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 19, 2022
…utter#102093)" (flutter#104039) This reverts commit f8f4387.
CaseyHillers
pushed a commit
that referenced
this pull request
May 19, 2022
chunhtai
added a commit
that referenced
this pull request
May 24, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
flutter#104110) * Reland "Fix Backbutton is not displayed when there is a endDrawer (flutter#102093)" This reverts commit a4a8e73. * add todos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the appbar infer backbutton from navigator.canpop, and Scaffold end drawer. It is hard to maintain. The internal use case is that they also want to backbutton to show up if there is a nested navigator in the route, so we have to provide a API to add appbar on route level as well.
This pr makes it so the ModalRoute.impliesAppBarDismissal is the single source of truth to add back button. There are two ways people can add backbutton.
fixes #80256
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.