Revert "Clipping if only one character text overflows" #102092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08e467d.
flutter-dashboard
bot
added
a: text input
CaseyHillers
approved these changes
Apr 18, 2022
Contributor
Author
|
@xu-baolin Can you open a revert PR of this? Then maybe I can post a specific reproduction of what was failing on the Google tests. Sorry we had to revert here, most of this is my fault for not checking my GitHub notifications on your original PR. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 18, 2022
xu-baolin
added a commit
that referenced
this pull request
Apr 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
8 tasks
godofredoc
added a commit
that referenced
this pull request
Apr 23, 2022
) (#102389) This reverts commit 08e467d (Google test failures after merge). Co-authored-by: Justin McCandless <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #99146
This made adjustments to text clipping, and some small sub-pixel changes to image comparison tests were expected. However, I see some Google tests breaking with clearly visible clipping changes.
Let's revert this and then we should see if we can reproduce the clipping changes to figure out how to avoid them.