-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Enable DeviceLab arm64 ios tests as bringup: true
#102089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DeviceLab arm64 ios tests as bringup: true
#102089
Conversation
.ci.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runIf should match their x86 equivalent
| - dev/** | |
| - dev/** | |
| - packages/flutter_tools/** | |
| - bin/** | |
| - .ci.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all builders to be consistent with x86.
|
A friendly ping. |
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @keyonghan!
c836840 to
ff8f1a2
Compare
This PR enables passing arm64 tests (staging) in prod. Initially as
bringup: true, they will be marked as blocking when validated.Context:
https://flutter-review.googlesource.com/c/infra/+/26927 enabled m1 tests in staging.
https://chrome-internal-review.googlesource.com/c/infradata/config/+/4680019 brought up 4 m1/ios testbeds in prod.
These tests have been passing consistently in staging:
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20hot_mode_dev_cycle_macos_target__benchmark
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20flutter_gallery_ios__compile
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20hello_world_ios__compile
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20native_ui_tests_ios
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20build_ios_framework_module_test
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20run_release_test_macos
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20ios_app_with_extensions_test
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20ios_content_validation_test
https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging%20macos_chrome_dev_mode
Issue: #87508