Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 15, 2022

Will be needed for the release after when flutter/engine#32664 rolls, which changes these paths.

See #97327

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically d: conductor labels Apr 15, 2022
@jmagman jmagman self-assigned this Apr 15, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 15, 2022
@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

@christopherfujino any idea how to test this? Other than that it will fail when we run the conductor and the paths have changed?

@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

Okay great this is tested, we'll wait until flutter/engine#32664 rolls then.

This usually happens either during an engine roll or a change to the caching
logic in flutter_tools. If this is a valid change, then the conductor source
code should be updated, specifically either the [binariesWithEntitlements] or
[binariesWithoutEntitlements] lists, depending on if the file should have macOS
entitlements applied during codesigning.

01:44 +18 -1: test/codesign_integration_test.dart: validate the expected binaries from the conductor codesign command are present in the cache [E]
Found unexpected binary in cache: /opt/s/w/ir/x/t/flutter_conductor_integration_test.XISN6L/flutter_conductor_checkouts/framework/bin/cache/artifacts/engine/ios-profile/Flutter.xcframework/ios-arm64_armv7/Flutter.framework/Flutter
package:test_api fail
test/codesign_integration_test.dart 71:7 main.

@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

Actually I guess this change needs to happen in a manual roll or this test won't pass on a roll with just flutter/engine#32664.

@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

Closing, I added to the engine roll #102012

@jmagman jmagman closed this Apr 15, 2022
@jmagman jmagman deleted the armv7-codesign branch May 4, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant