[flutter_tools] explicitly enable macos-desktop in macos_content_validation_test.dart #102009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
christopherfujino
changed the title
jmagman
reviewed
Apr 15, 2022
| processManager.runSync(<String>[ | ||
| flutterBin, | ||
| 'config', | ||
| '--enable-macos-desktop', |
Member
There was a problem hiding this comment.
Can we do it for all tool shards? instead of per test?
Line 587 in 0d08756
Member
There was a problem hiding this comment.
Actually it doesn't matter, if we see it again we can hoist it up.
jmagman
approved these changes
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 16, 2022
…ent_validation_test.dart (flutter/flutter#102009)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
…ent_validation_test.dart (flutter/flutter#102009)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102008